[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] credit: track residual from divisions done during accounting



On 02/26/2013 12:21 PM, Ian Campbell wrote:
On Tue, 2013-02-26 at 12:00 +0000, David Vrabel wrote:
On 26/02/13 11:52, Tim Deegan wrote:
How about ASSERT(((typeof credits) val) == val) before the assignment?

Why not just
        ASSERT(credits == val); /* Ensure we haven't truncated val */

I prefer this one to having "typeof credits" in the ASSERT. The main thing is just to minimize the amount of effort a programmer has to expend trying to figure out what's going on, so he can spend it on something else. :-)

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.