Re: [Xen-devel] [PATCH] qemu: define a TOM register to report the base of PCI

["Hao, Xudong" <xudong.hao@xxxxxxxxx>]

> -----Original Message-----
> From: Stefano Stabellini [mailto:stefano.stabellini@xxxxxxxxxxxxx]
> Sent: Friday, February 22, 2013 8:35 PM
> To: Hao, Xudong
> Cc: aliguori@xxxxxxxxxx; mst@xxxxxxxxxx; qemu-devel@xxxxxxxxxx;
> Stefano Stabellini; xen-devel@xxxxxxxxxxxxx; Zhang, Xiantao
> Subject: Re: [PATCH] qemu: define a TOM register to report the base of PCI
> 
> On Fri, 22 Feb 2013, Xudong Hao wrote:
> > Define a TOM(top of memory) register to report the base of PCI memory,
> update
> > memory region dynamically.
> >
> > The use case of this register defination is for Xen till now.
> >
> > Signed-off-by: Xudong Hao <xudong.hao@xxxxxxxxx>
> > Signed-off-by: Xiantao Zhang <xiantao.zhang@xxxxxxxxx>
> 
> Thanks for the patch!
> 
> Aside from Jan's comment on the pci config endianness, I would also like
> to see an #define somewhere in QEMU to specific what's the default TOM.
> In particular I wouldn't want 0xe0000000 (and 0xf0000000) to be
> hardcoded in more than one place.
> 
> 
Good comments, I'll define the default TOM out and replace the hardcode.

Thanks,
-Xudong

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel