Re: [Xen-devel] [PATCH v7 1/5] xen: introduce a generic framebuffer driver

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 15 Feb 2013, Ian Campbell wrote:
> On Thu, 2013-02-14 at 17:30 +0000, Stefano Stabellini wrote:
> >  xen/drivers/video/Makefile |    1 +
> >  xen/drivers/video/lfb.c    |  183 
> > ++++++++++++++++++++++++++++++++++++++++++++
> >  xen/drivers/video/lfb.h    |   46 +++++++++++
> >  xen/drivers/video/vesa.c   |  177 
> > ++++++------------------------------------
> 
> On x86_64;
> 
> vesa.c: In function âvesa_initâ:
> vesa.c:126: error: âfbpâ undeclared (first use in this function)
> vesa.c:126: error: (Each undeclared identifier is reported only once
> vesa.c:126: error: for each function it appears in.)
> 
> I think this fixes it, if it does then I'm happy to role in as I apply.

Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>


> diff --git a/xen/drivers/video/vesa.c b/xen/drivers/video/vesa.c
> index 1fbe959..575db62 100644
> --- a/xen/drivers/video/vesa.c
> +++ b/xen/drivers/video/vesa.c
> @@ -123,7 +123,7 @@ void __init vesa_init(void)
>      {
>          /* Light grey in truecolor. */
>          unsigned int grey = 0xaaaaaaaa;
> -        fbp.pixel_on =
> +        lfbp.pixel_on =
>              ((grey >> (32 - vlfb_info.  red_size)) << vlfb_info.  red_pos) |
>              ((grey >> (32 - vlfb_info.green_size)) << vlfb_info.green_pos) |
>              ((grey >> (32 - vlfb_info. blue_size)) << vlfb_info. blue_pos);
> @@ -131,7 +131,7 @@ void __init vesa_init(void)
>      else
>      {
>          /* White(ish) in default pseudocolor palette. */
> -        fbp.pixel_on = 7;
> +        lfbp.pixel_on = 7;
>      }
>  
>      if ( lfb_init(&lfbp) < 0 )
> 
> 
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel