Re: [Xen-devel] [PATCH 33/45] xen: arm: make dom0 builder work on 64-bit hypervisor

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2013-02-14 at 15:18 +0000, Tim Deegan wrote:
> At 15:56 +0000 on 23 Jan (1358956599), Ian Campbell wrote:
> > @@ -299,6 +299,12 @@ int construct_dom0(struct domain *d)
> >      if ( rc < 0 )
> >          return rc;
> >  
> > +#ifdef CONFIG_ARM_64
> > +    printk(" Xen kernel: 64-bit, AArch64, AArch32\n");
> > +#else
> > +    printk(" Xen kernel: 32-bit, AArch32\n");
> > +#endif
> 
> A debugging printk left over?  It seems misleading, since dom0 is
> AArch32 in any case, and it's got a leading space.

It's the equivalent to this print on x86:
    printk(" Xen  kernel: 64-bit, lsb, compat32\n");

I think this is 64-bit followed by the capabilities? I could happily
drop,

It's indented because it ought to be followed by the equivalent to 
    printk(" Dom0 kernel: %s%s, %s, paddr %#" PRIx64 " -> %#" PRIx64 "\n",
           elf_64bit(&elf) ? "64-bit" : "32-bit",
           parms.pae       ? ", PAE"  : "",
           elf_msb(&elf)   ? "msb"    : "lsb",
           elf.pstart, elf.pend);
but it isn't.

On ARM this message is probably worthless in its current form, I'll
remove it.

> 
> Otherwise, 
> 
> Acked-by: Tim Deegan <tim@xxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel