Re: [Xen-devel] [PATCH 2/2] AMD IOMMU: handle MSI for phantom functions

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-02-06 at 13:12 +0000, Jan Beulich wrote:
> @@ -379,12 +382,30 @@ void amd_iommu_msi_msg_update_ire(
>      }
>  
>      if ( msi_desc->remap_index >= 0 )
> -        update_intremap_entry_from_msi_msg(iommu, bdf, msi_desc, NULL);
> +    {
> +        do {
> +            update_intremap_entry_from_msi_msg(iommu, bdf,
> +                                               &msi_desc->remap_index, NULL);
> +            if ( !pdev || !pdev->phantom_stride )
> +                break;
> +            bdf += pdev->phantom_stride;
> +        } while ( PCI_SLOT(bdf) == PCI_SLOT(pdev->devfn) );
> +
> +        msi_desc->remap_index = -1;

The reason for this reset is a bit subtle, but I think I get it, might
be worth a comment though.

Otherwise: Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
(although with similar caveats to 1/2)

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel