Re: [Xen-devel] [PATCH V2 14/15] Only allow 3-level event channel on Dom0 and driver domain

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.02.13 at 18:23, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> @@ -411,6 +413,9 @@ struct domain *domain_create(
>   /* DOMCRF_oos_off: dont use out-of-sync optimization for shadow page tables 
> */
>  #define _DOMCRF_oos_off         4
>  #define DOMCRF_oos_off          (1U<<_DOMCRF_oos_off)
> +/* DOMCRF_evtchn_l3: this domain can use 3-level event channel (driver 
> domain) */
> +#define _DOMCRF_evtchn_l3     5
> +#define DOMCRF_evtchn_l3      (1U<<_DOMCRF_evtchn_l3)

Please don't use "l3" in this name; instead, make it generic to say
"extended event channels" in some way.

Also, the patch description should explain why this restriction is
being put in place.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel