[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] HVM guests hanging in hpet_rtc_interrupt



>>> On 04.02.13 at 09:21, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:
> Looking over the changes again (and without having looked at
> the Linux side yet again), I think the most likely candidates for
> reverting are
> 
> 26457:aa82638d58b0 (x86/HVM: consolidate toggling of RTC IRQ)
> 26461:78e91e9e4d61 (x86/HVM: generalize IRQ raising on RTC_REG_B writes)

Actually, one possibility occurred to me right after sending the
earlier response - could you give the patch below a try?

Jan

--- a/xen/arch/x86/hvm/rtc.c
+++ b/xen/arch/x86/hvm/rtc.c
@@ -55,6 +55,8 @@ static void rtc_toggle_irq(RTCState *s)
     struct domain *d = vrtc_domain(s);
 
     ASSERT(spin_is_locked(&s->lock));
+    if ( s->hw.cmos_data[RTC_REG_C] & RTC_IRQF )
+        return;
     s->hw.cmos_data[RTC_REG_C] |= RTC_IRQF;
     hvm_isa_irq_deassert(d, RTC_IRQ);
     hvm_isa_irq_assert(d, RTC_IRQ);



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.