Re: [Xen-devel] [PATCH v2] Fix scheduler crash after s3 resume

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 24/01/13 15:36, Jan Beulich wrote:
> > > > On 24.01.13 at 15:26, Tomasz Wroblewski <tomasz.wroblewski@xxxxxxxxxx> wrote:
> > @@ -212,6 +213,8 @@
> >              BUG_ON(error == -EBUSY);
> >              printk("Error taking CPU%d up: %d\n", cpu, error);
> >          }
> > +        if (system_state == SYS_STATE_resume)
> > +            cpumask_set_cpu(cpu, cpupool0->cpu_valid);
> This can't be right: What tells you that all CPUs were in pool 0?
>
> Also, for the future - generating patches with -p helps quite
> a bit in reviewing them.
If you're using mercurial e-mail / mercurial queues, you can get this 
effect by adding the following lines to your ~/.hgrc:
[diff]
showfunc = True
nodates = 1
git = 1

 -George


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel