Re: [Xen-devel] [PATCH] libxc, libxenstore: make the headers C++-friendly

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.01.13 at 18:02, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> On Tue, 2013-01-22 at 16:53 +0000, Jan Beulich wrote:
>> >>> On 22.01.13 at 17:44, Razvan Cojocaru <rzvncj@xxxxxxxxx> wrote:
>> > --- a/xen/include/public/io/ring.h Mon Jan 21 17:03:10 2013 +0000
>> > +++ b/xen/include/public/io/ring.h Tue Jan 22 18:43:45 2013 +0200
>> > @@ -111,7 +111,7 @@ struct __name##_sring {                 
>> >              uint8_t msg;                                                \
>> >          } tapif_user;                                                   \
>> >          uint8_t pvt_pad[4];                                             \
>> > -    } private;                                                          \
>> > +    } rprivate;                                                          \
>> 
>> This is a no-go: In a public header, you can't change names like
>> this. Since the stuff under io/ isn't really tied to
>> __XEN_INTERFACE_VERSION__, I'm also not immediately seeing
>> how else you could adjust this.
> 
> Me neither. Perhaps everyone uses the macros and we get away with this
> change?

No, we won't - netif has "smartpoll_active" defined inside that
sub-structure (not sure where that's being used though), and
blktap2 has a "msg" field there.

> Was this change build tested, including stubdoms and other tools which
> may rely on these headers? (qemu?)

Obviously not, at least not tools/blktap2/drivers/tapdisk-vbd.c
and (with a suitably synchronized header) linux-2.6.18-xen.hg.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel