Re: [Xen-devel] [RFC PATCH V2 14/14] Implement 3-level event channel routines

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 21.01.13 at 15:30, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> @@ -1163,6 +1250,22 @@ static void __evtchn_setup_bitmap_l3(struct domain *d)
>             sizeof(shared_info(d, evtchn_mask)));
>  }
>  
> +static struct xen_evtchn_ops __read_mostly xen_evtchn_ops_l2 = {
> +    .set_pending      = evtchn_set_pending_l2,
> +    .clear_pending    = evtchn_clear_pending_l2,
> +    .unmask           = evtchn_unmask_l2,
> +    .is_pending       = evtchn_is_pending_l2,
> +    .is_masked        = evtchn_is_masked_l2,
> +};
> +
> +static struct xen_evtchn_ops __read_mostly xen_evtchn_ops_l3 = {
> +    .set_pending      = evtchn_set_pending_l3,
> +    .clear_pending    = evtchn_clear_pending_l3,
> +    .unmask           = evtchn_unmask_l3,
> +    .is_pending       = evtchn_is_pending_l3,
> +    .is_masked        = evtchn_is_masked_l3,
> +};
> +
>  static long evtchn_register_3level(
>      XEN_GUEST_HANDLE_PARAM(evtchn_register_3level_t) arg)
>  {

Could you arrange for the movement of xen_evtchn_ops_l2 to not
be necessary here (perhaps by adjusting earlier patches)?

Jan

> @@ -1481,14 +1581,6 @@ void notify_via_xen_event_channel(struct domain *ld, 
> int lport)
>      spin_unlock(&ld->event_lock);
>  }
>  
> -static struct xen_evtchn_ops __read_mostly xen_evtchn_ops_l2 = {
> -    .set_pending      = evtchn_set_pending_l2,
> -    .clear_pending    = evtchn_clear_pending_l2,
> -    .unmask           = evtchn_unmask_l2,
> -    .is_pending       = evtchn_is_pending_l2,
> -    .is_masked        = evtchn_is_masked_l2,
> -};
> -
>  int evtchn_init(struct domain *d)
>  {
>      BUILD_BUG_ON(sizeof(struct evtchn *) * NR_EVTCHN_BUCKETS > PAGE_SIZE);



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel