Re: [Xen-devel] [PATCH 1/4] tools: install under /usr/local by default.

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On 18/01/13 15:25, Ian Campbell wrote:
> This is the defacto (or FHS mandated?) standard location for software
> built from source, in order to avoid clashing with packaged software
> which is installed under /usr/bin etc.
> 
> I think there is benefit in having Xen's install behave more like the
> majority of other OSS software out there.
> 
> The major downside here is in the transition from 4.2 to 4.3 where
> people who have built from source will innevitably discover breakage
> because 4.3 no longer overwrites stuff in /usr like it used to so they
> pickup old stale bits from /usr instead of new stuff from /usr/local.
> 
> Packages will use ./configure --prefix=/usr or whatever helper macro
> their package manager gives them. I have confirmed that doing this
> results in the same list of installed files as before this patch was
> applied.
> 
> Note that this does not currently affect docs or stubdoms at the
> moment, so they still end up under /usr. There are proposals to use
> configure here too at which point I would propose a similar patch and
> these would also move as expected (depending on the sequencing I may
> end folding that into this patch)

I think the above paragraph is no longer true, you are modifying
stubdoms configure to use the default prefix. Also the subject should be
updated to "tools/stubdom:" or a similar prefix.

> The hypervisor remains in /boot/ and there is no intention to move it.
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Apart from the above comment, the code itself looks right, so:

Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel