Re: [Xen-devel] [PATCH 2/3] tools:libxl: Add qxl vga interface support v2

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

On Wed, Nov 21, 2012 at 11:02 AM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:

On Wed, 2012-11-21 at 03:27 +0000, ZhouPeng wrote:
> I think, the key idea is just to support the default for qxl (128Mib)
> in the discussion.
> videoram is not designed for qxl video ram.
> > If we reject values which are <128M, and clamp anything which is >128M
> > to 128M then what is the point of the option?
>
> This piece of code doesn't mean to use videoram option to assign memory for qxl.
> Because videoram option comes in Xen before qxl, it need to be consided here.

You mean because video_memkb is used for VGA when QXL is disabled and
QXL when it is? So the confusion here arises because this field is doing
double duty.

Perhaps it would be better to add a separate notion of qxl_memkb? The
code in libxl__build_device_model_args_new and perhaps a handful of
other places would need to account for either videoram or qxlram
depending on which was enabled (you'd probably want a helper function
for this).

Is it possible to enable both VGA and QXL for a domain?

What's the status of this patch?

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel