Re: [Xen-devel] [PATCH 06/20] xen: Simplify halting of first CPU

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Tue, 15 Jan 2013, Andreas FÃrber wrote:
> Use the global first_cpu variable to halt the CPU rather than using a
> local first_cpu initialized from qemu_get_cpu(0).
> 
> This will allow to change qemu_get_cpu() return type to CPUState
> despite use of the CPU_COMMON halted field in the reset handler.
> 
> Signed-off-by: Andreas FÃrber <afaerber@xxxxxxx>

Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

>  xen-all.c |    4 +---
>  1 Datei geÃndert, 1 Zeile hinzugefÃgt(+), 3 Zeilen entfernt(-)
> 
> diff --git a/xen-all.c b/xen-all.c
> index 19bcfd1..110f958 100644
> --- a/xen-all.c
> +++ b/xen-all.c
> @@ -585,9 +585,7 @@ static void xen_reset_vcpu(void *opaque)
>  
>  void xen_vcpu_init(void)
>  {
> -    CPUArchState *first_cpu;
> -
> -    if ((first_cpu = qemu_get_cpu(0))) {
> +    if (first_cpu != NULL) {
>          qemu_register_reset(xen_reset_vcpu, first_cpu);
>          xen_reset_vcpu(first_cpu);
>      }
> -- 
> 1.7.10.4
> 
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel