Re: [Xen-devel] [PATCH v2 3/3] nested vmx: fix CR0/CR4 emulation

["Nakajima, Jun" <jun.nakajima@xxxxxxxxx>]

On Fri, Jan 11, 2013 at 7:47 AM, Xu, Dongxiao <dongxiao.xu@xxxxxxxxx> wrote:
> > -----Original Message-----
> > From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> > Sent: Friday, January 11, 2013 4:09 PM
> > To: Xu, Dongxiao
> > Cc: Dong, Eddie; Nakajima, Jun; xen-devel@xxxxxxxxxxxxx
> > Subject: RE: [Xen-devel] [PATCH v2 3/3] nested vmx: fix CR0/CR4
> > emulation
> >
> > >>> On 11.01.13 at 01:45, "Xu, Dongxiao" <dongxiao.xu@xxxxxxxxx> wrote:
> > >>  -----Original Message-----
> > >> From: xen-devel-bounces@xxxxxxxxxxxxx
> > >> [mailto:xen-devel-bounces@xxxxxxxxxxxxx] On Behalf Of Dongxiao Xu
> > >> Sent: Monday, January 07, 2013 2:42 PM
> > >> To: xen-devel@xxxxxxxxxxxxx
> > >> Subject: [Xen-devel] [PATCH v2 3/3] nested vmx: fix CR0/CR4 emulation
> > >
> > > I saw this patch is not checked in yet, do you have comments on this
> > > one?
> >
> > No, but other than for the two other ones which I could review
> > myself easily enough, I'd expect an ack from Jun or Eddie
> > (or one of the other x86 maintainers) on this one.
> >
> > In general, with VMX patches coming from people at Intel it would
> > certainly help if you asked your colleagues to do the first review
> > round before you even submit, indicating it happened by attaching
> > the respective tag from the beginning.
>
> OK, I will CC Jun and Eddie by default if sending later patches.
> And for this patch, Eddie acked it in another mail.
>
> Thanks,
> Dongxiao
>
> >
> > Jan

One comment:

> +            case VMX_CONTROL_REG_ACCESS_TYPE_MOV_TO_CR:
> +            {
> +                unsigned long gp = 
> VMX_CONTROL_REG_ACCESS_GPR(exit_qualification);
> +                unsigned long *reg;
> +                if ( (reg = decode_register(gp, guest_cpu_user_regs(), 0)) 
> == NULL )
> +                {
> +                    gdprintk(XENLOG_ERR, "invalid gpr: %lx\n", gp);
> +                    break;
> +                }
> >

What happens after the "break" (if it really happens), or how the
error is handled?


--
Jun
Intel Open Source Technology Center

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel