Re: [Xen-devel] [PATCH v4 08/10] nEPT: handle invept instruction from L1 VMM

["Zhang, Xiantao" <xiantao.zhang@xxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: Friday, January 04, 2013 4:25 PM
> To: Zhang, Xiantao
> Cc: Dong, Eddie; Nakajima, Jun; xen-devel@xxxxxxxxxxxxx; keir@xxxxxxx;
> tim@xxxxxxx
> Subject: RE: [PATCH v4 08/10] nEPT: handle invept instruction from L1 VMM
> 
> >>> On 04.01.13 at 01:57, "Zhang, Xiantao" <xiantao.zhang@xxxxxxxxx>
> wrote:
> >> >
> >> > +int nvmx_handle_invept(struct cpu_user_regs *regs) {
> >> > +    struct vmx_inst_decoded decode;
> >> > +    unsigned long eptp;
> >> > +    u64 inv_type;
> >> > +
> >> > +    if ( decode_vmx_inst(regs, &decode, &eptp, 0) != X86EMUL_OKAY )
> >> > +        return X86EMUL_EXCEPTION;
> >>
> >> So in the overview you said you fixed this, but here it is again:
> >> There are more than the two X86EMUL_* values referenced above, and
> >> hence you can't imply that if it's not one, it's the other.
> >
> > Do you mean X86EMUL_EXCEPTION can't be returned here ?
> 
> No - I'm trying to tell you that you should return whatever
> decode_vmx_inst() returned.
Considering the caller doesn't care non-X86EMUL_OKAY case,  so here just return 
X86EMUL_EXCEPTION. Anyway, I will change it.  Thanks!
Xiantao


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel