Re: [Xen-devel] [RFC PATCH 2/3] Dynamically allocate domain->evtchn, also bump EVTCHNS_PER_BUCKET to 512.

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 31/12/12 18:22, Wei Liu wrote:
> From: Wei Liu <liuw@xxxxxxxxx>

The changeset description needs to say why you're increasing
EVTCHNS_PER_BUCKET.  I can't tell why.

> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
>  xen/common/event_channel.c |    8 ++++++++
>  xen/include/xen/sched.h    |    4 ++--
>  2 files changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c
> index 87e422e..9898f8e 100644
> --- a/xen/common/event_channel.c
> +++ b/xen/common/event_channel.c
> @@ -1172,6 +1172,12 @@ void notify_via_xen_event_channel(struct domain *ld, 
> int lport)
>  
>  int evtchn_init(struct domain *d)
>  {
> +    d->evtchn = (struct evtchn **)
> +        xzalloc_array(struct evtchn *, NR_EVTCHN_BUCKETS);

Don't need the cast here?

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel