Re: [Xen-devel] [PATCH] libxc: Add xc_domain_hvm_get_mtrr_type() call

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2012-12-17 at 11:38 +0000, Razvan Cojocaru wrote:
> Add a xc_domain_hvm_get_mtrr_type() call to the libxc API,
> to support functionality similar to get_mtrr_type() (which
> is only available at the hypervisor level).

Do you have a user in mind for this new functionality?

> Signed-off-by: Razvan Cojocaru <rzvncj@xxxxxxxxx>
> 
> diff -r f50aab21f9f2 -r a23515aabc91 tools/libxc/xc_domain.c
> --- a/tools/libxc/xc_domain.c Thu Dec 13 14:39:31 2012 +0000
> +++ b/tools/libxc/xc_domain.c Mon Dec 17 12:53:11 2012 +0200
> @@ -379,6 +379,45 @@ int xc_domain_hvm_setcontext(xc_interfac
>      return ret;
>  }
>  
> +#define MTRR_PHYSMASK_VALID_BIT  11
> +#define MTRR_PHYSMASK_SHIFT      12
> +#define MTRR_PHYSBASE_TYPE_MASK  0xff   /* lowest 8 bits */
> +
> +int xc_domain_hvm_get_mtrr_type(xc_interface *xch, 
> +                                uint32_t domid,
> +                                unsigned long paddress,
> +                                uint8_t *type)
> +{

This version seems to do a lot less than get_mtrr_type() in the
hypervisor. Is that deliberate? Why isn't the fixed mtrr slot and
overlap handling required here?

> [...]

> diff -r f50aab21f9f2 -r a23515aabc91 tools/libxc/xenctrl.h
> --- a/tools/libxc/xenctrl.h   Thu Dec 13 14:39:31 2012 +0000
> +++ b/tools/libxc/xenctrl.h   Mon Dec 17 12:53:11 2012 +0200
> @@ -633,6 +633,15 @@ int xc_domain_hvm_setcontext(xc_interfac
>                               uint32_t size);
>  
>  /**
> + * This function returns information about the MTRR type of
> + * a given guest physical address/

                                   ^ you mean . not / I think.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel