Re: [Xen-devel] [PATCH] Disable caml-stubdom by default

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

*Please* can you stop top posting.

    A: Because it messes up the order in which people normally read text.
    Q: Why is top-posting such a bad thing?

On Fri, 2012-12-14 at 16:20 +0000, Fioravante, Matthew E. wrote:
> I thought the purpose of caml stubdom like c stubdom is an example for
> developing new domains. If that is the case, then I don't think it
> makes sense to build and install it by default. End users who are just
> building and installing xen don't need to have it.
> 
> The other problem is that c-stubdom and caml-stubdom have main()
> functions but also define CONFIG_TEST=y in their config files. The
> test framework also defines a main() function, causing a multiple
> definition linker error.
> 
> Whats the intention here? Do we want them to run the test code or do
> we want them to just be simple stubs with hello world main functions?

I think the Caml one should certainly drop CONFIG_TEST. Any "test"
behaviour of that domain should be done in ocaml not in C.

For the C one I'm less sure. I'd be in favour of nuking it but then
nothing (AFAIK) would be using CONFIG_TEST. Since the C one doesn't
really do anything else I guess it may as well continue to be the
CONFIG_TEST-bed. But then main might as well be nuked.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel