Re: [Xen-devel] [PATCH RFC/v2] libxl: postpone backend name resolution

[Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>]

On 12/17/2012 04:57 AM, Ian Campbell wrote:
> On Thu, 2012-12-13 at 21:47 +0000, Daniel De Graaf wrote:
>> This replaces the backend_domid field in libxl devices with a structure
>> allowing either a domid or a domain name to be specified.  The domain
>> name is resolved into a domain ID in the _setdefault function when
>> adding the device.  This change allows the backend of the block devices
>> to be specified (which previously required passing the libxl_ctx down
>> into the block device parser).
> 
> I didn't review this in detail yet but my first thought was that this is
> a libxl API change, and I can't see any provision for backwards
> compatibility.

Nope, I forgot to address that this version. Will send v3 soon.

> If you are doing something clever which I've missed then it deserves a
> comment ;-)
> 
> Assuming not then the simplest solution would be to remove the struct
> and just add the name as a field to each affected device. Or maybe an
> anonymous struct would do the job if the members were backend_domid and
> backend_name?

I think just adding the field would work better; the anonymous struct seems
like it might be compiler-dependent.  It's not significantly more code in
the setdefault functions to avoid using the struct.

> You could also potentially do something with the provisions around
> LIBXL_API_VERSION documented in libxl.h.
> 
> Ian.
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel