[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 3 of 6 v2] xen: sched_credit: use current_on_cpu() when appropriate



On Fri, 2012-12-14 at 19:39 +0000, George Dunlap wrote: 
> Hmm, I hadn't read this patch when I commented about removing the macro 
> from the first patch. :-)
> 
:-)

> I personally think that using vc->processor is better in that patch 
> anyway; but using this macro elsewhere is probably fine.
> 
Ok.

> I think from a taste point of view, I would have put this patch, with 
> the new definition, as the first patch in the series, and the had the 
> second patch just use it.
> 
Ok then, when respinning I'll have the first patch defining and using
the macro. Then I'll have the 'fix picking' patch using vc->processor
_instead_ the macro. Yes, that kills the need for the macro, but since I
already have the code for it, and I think things with it does look a bit
better, I won't actually kill it. Let me know (here or replying to the
corresponding e-mail in the reposting) if you don't want it.

Thanks and Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.