Re: [Xen-devel] [PATCH V3] libxenstore: filter watch events in libxenstore when we unwatch

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Julien Grall writes ("Re: [PATCH V3] libxenstore: filter watch events in 
libxenstore when we unwatch"):
> On 12/13/2012 06:35 PM, Ian Jackson wrote:
> > XS_UNWATCH_FILTER ?  XS_WATCH_TOKENS_UNIQUE ?
> 
> I think XS_UNWATCH_FILTER is better.

OK.

> > As for the documentation:
> 
> I think it's too restrictive for upstream. xs_unwatch could only filter
> following the token and the subpath. I modified your documentation
> proposal below to take into account this solution. What do you think?

I like your proposal.

      *    A path and a subpath can be       The application must avoid to
      *    register with the same token.     register a path (/foo/) and

A tiny grammar quibble: you should write "the application must avoid
registering".  "Avoid" needs the FOOing form of a verb rather than the
"to FOO" form.

> I will fix the test by using xs_path_is_subpath.

Great.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel