Re: [Xen-devel] [PATCH 2/2] 4.1.2 blktap2 cleanup fixes.

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Dr. Greg Wettstein writes ("[PATCH 2/2] 4.1.2 blktap2 cleanup fixes."):
> ---------------------------------------------------------------------------
> The following patch when applied on top of:
> 
> libxl: attempt to cleanup tapdisk processes on disk backend destroy.
> 
> Establishes correct cleanup behavior for blktap devices.  This patch
> implements the release of the backend device before calling for
> the destruction of the userspace component of the blktap device.
> 
> Without this patch the kernel xen-blkback driver deadlocks with
> the blktap2 user control plane until the IPC channel is terminated by the
> timeout on the select() call.  This results in a noticeable delay
> in the termination of the guest and causes the blktap minor
> number which had been allocated to be orphaned.

This looks plausible.  But shouldn't it be applied to xen-unstable and
Xen 4.2 too ?

>      if (atoi(state) != 4) {
> -        libxl__device_destroy_tapdisk(&gc, be_path);
> -        xs_rm(ctx->xsh, XBT_NULL, be_path);
> +     libxl__device_destroy_tapdisk(&gc, be_path);
>          goto out;

And this contains a whitespace change.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel