[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 14/14] stubdom/Makefile: Fix gmp extract rule



Daniel De Graaf, le Mon 10 Dec 2012 14:55:47 -0500, a écrit :
>  gmp-$(XEN_TARGET_ARCH): gmp-$(GMP_VERSION).tar.bz2 $(NEWLIB_STAMPFILE)
>       tar xjf $<
> +     rm $@ -rf || :

I'm realizing...

>       mv gmp-$(GMP_VERSION) $@
>       #patch -d $@ -p0 < gmp.patch
>       cd $@; CPPFLAGS="-isystem 
> $(CROSS_PREFIX)/$(GNU_TARGET_ARCH)-xen-elf/include $(TARGET_CPPFLAGS)" 
> CFLAGS="$(TARGET_CFLAGS)" CC=$(CC) $(GMPEXT) ./configure --disable-shared 
> --enable-static --disable-fft --without-readline 
> --prefix=$(CROSS_PREFIX)/$(GNU_TARGET_ARCH)-xen-elf

Which is configure invoked here?  In the other cases, we have used a
stampfile, to separate unpacking and configure stages, which avoids the
issue.  Is it because libgmp does not support build out of tree?  If so,
then I'm fine with the rm change, although -rm $@ -rf instead of || :
would be more readable.

Samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.