[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86: properly fail mmuext ops when get_page_from_gfn() fails


  • To: Jan Beulich <JBeulich@xxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxx>
  • Date: Thu, 06 Dec 2012 15:55:18 +0000
  • Delivery-date: Thu, 06 Dec 2012 15:55:58 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>
  • Thread-index: Ac3TyhafaKAohMiMCEeOjnaLn+ePLg==
  • Thread-topic: [Xen-devel] [PATCH] x86: properly fail mmuext ops when get_page_from_gfn() fails

On 06/12/2012 12:59, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:

> I noticed this inconsistency while analyzing the code for XSA-32.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Keir Fraser <keir@xxxxxxx>

> --- a/xen/arch/x86/mm.c
> +++ b/xen/arch/x86/mm.c
> @@ -2776,7 +2776,7 @@ long do_mmuext_op(
>              page = get_page_from_gfn(pg_owner, op.arg1.mfn, NULL, P2M_ALLOC);
>              if ( unlikely(!page) )
>              {
> -                rc = -EINVAL;
> +                okay = 0;
>                  break;
>              }
>  
> @@ -2836,6 +2836,7 @@ long do_mmuext_op(
>              page = get_page_from_gfn(pg_owner, op.arg1.mfn, NULL, P2M_ALLOC);
>              if ( unlikely(!page) )
>              {
> +                okay = 0;
>                  MEM_LOG("Mfn %lx bad domain", op.arg1.mfn);
>                  break;
>              }
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.