Re: [Xen-devel] [PATCH 3 of 3] xen: sched_credit: add some tracing

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 03/12/12 16:35, Dario Faggioli wrote:
> +            /* Avoid TRACE_* to avoid a lot of useless !tb_init_done checks */
> +            for_each_cpu(cpu, &mask)
> +            {
> +                struct {
> +                    unsigned cpu:8;
> +                } d;
> +                d.cpu = cpu;
> +                trace_var(TRC_CSCHED_TICKLE, 0,
> +                          sizeof(d),
> +                          (unsigned char*)&d);
Why not just TRC_1D()?  The tracing infrastructure can only set the size 
at a granularity of 32-bit words anyway, and at this point cpu is 
"unsigned int", which will be a single word.
Other than that, everything looks good.

 -George


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel