Re: [Xen-devel] [PATCH 12/15] xen: arm: initialise dom_{xen, io, cow}

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2012-12-04 at 14:17 +0000, David Vrabel wrote:
> On 04/12/12 11:56, Ian Campbell wrote:
> > +void __init arch_init_memory(void)
> > +{
> > +    /*
> > +     * Initialise our DOMID_XEN domain.
> > +     * Any Xen-heap pages that we will allow to be mapped will have
> > +     * their domain field set to dom_xen.
> > +     */
> > +    dom_xen = domain_create(DOMID_XEN, DOMCRF_dummy, 0);
> > +    BUG_ON(IS_ERR(dom_xen));
> > +
> > +    /*
> > +     * Initialise our DOMID_IO domain.
> > +     * This domain owns I/O pages that are within the range of the 
> > page_info
> > +     * array. Mappings occur at the priv of the caller.
> > +     */
> > +    dom_io = domain_create(DOMID_IO, DOMCRF_dummy, 0);
> > +    BUG_ON(IS_ERR(dom_io));
> > +
> > +    /*
> > +     * Initialise our COW domain.
> > +     * This domain owns sharable pages.
> > +     */
> > +    dom_cow = domain_create(DOMID_COW, DOMCRF_dummy, 0);
> > +    BUG_ON(IS_ERR(dom_cow));
> > +}
> 
> This looks like a cut and paste from the x86 code.  Should it be
> refactored into a common function?

Yes, I suppose it should. I guess this is the counterpoint to my
observation that there is x86 stuff in generic code ;-)

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel