Re: [Xen-devel] [PATCH 4 of 5 RFC] blktap3: Introduce xenio daemon Makefile

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2012-11-28 at 14:20 +0000, Thanos Makatos wrote:
> diff -r 7126fda14249 -r 0f3b6811dad1 tools/blktap3/xenio/Makefile
> --- /dev/null Thu Jan 01 00:00:00 1970 +0000
> +++ b/tools/blktap3/xenio/Makefile    Wed Nov 28 14:18:46 2012 +0000
> @@ -0,0 +1,47 @@
> +XEN_ROOT := $(CURDIR)/../../../
> +include $(XEN_ROOT)/tools/Rules.mk
> +
> +BLKTAP_ROOT := ..
> +
> +INST_DIR ?= /usr/bin
> +
> +IBIN = xenio
> +
> +override CFLAGS += \
> +     -I$(BLKTAP_ROOT)/include \
> +     -I$(BLKTAP_ROOT)/control \
> +     -I$(XEN_ROOT)/tools/libxc \
> +     -I$(XEN_ROOT)/tools/xenstore \

$(CFLAGS_libxenstore) and $(CFLAGS_libxenctrl) please.

> +     -D_GNU_SOURCE \
> +     $(CFLAGS_xeninclude) \
> +    -Wall \
> +    -Wextra \
> +    -Werror
> +
> +# FIXME cause trouble
> +override CFLAGS += \
> +    -Wno-old-style-declaration \
> +    -Wno-sign-compare \
> +    -Wno-type-limits
> +
> +override LDFLAGS = \
> +    -L$(XEN_ROOT)/tools/xenstore -lxenstore

$(LDFLAGS_libxenstore)

You have xenctrl CFLAGS but not LDFLAGS, is that right?

> +
> +XENIO-OBJS := log.o
> +
> +all: $(IBIN)
> +
> +$(BLKTAP_ROOT)/control/libblktapctl.a:
> +     make -C $(BLKTAP_ROOT)/control libblktapctl.a

Can you use SUBDIRS in the normal way for this?

> +$(IBIN): $(XENIO-OBJS) xenio.o $(BLKTAP_ROOT)/control/libblktapctl.a

Static linking on purpose?

If this is a purely internal library then fine, but I have a feeling
that libblktapctl is intended as an interface library which others (e.g.
libxl) will want to use?

> +     $(CC) -o $@ $^ $(LDFLAGS)
> +
> +install: all
> +     $(INSTALL_DIR) -p $(DESTDIR)$(INST_DIR)
> +     $(INSTALL_PROG) $(IBIN) $(DESTDIR)$(INST_DIR)
> +
> +clean:
> +     rm -f *.o *.o.d .*.o.d $(IBIN)
> +
> +.PHONY: clean install
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel