Re: [Xen-devel] Please ack XENMEM_claim_pages hypercall?

[Tim Deegan <tim@xxxxxxx>]

At 10:31 +0000 on 27 Nov (1354012308), Ian Campbell wrote:
> On Tue, 2012-11-27 at 08:48 +0000, Jan Beulich wrote:
> > Second, while I said the code itself looks acceptable, I also pointed
> > out that in the shape it is right now it is dead code, as there's no
> > user for it. So all we would get would be the risk of new bugs (and
> > the one I just pointed out worries me in so far as how much testing
> > this code really has seen).
> 
> I agree with this.

Me too (and with Jan and Ian's other points).

> > Third, deferral (or denial) of the patch going in is certainly not a
> > blocking factor for tools side development at Oracle. In the worst
> > case, you'd have to maintain the patch in your own tree(s); I do
> > realize that you want to avoid that (as I would, but there are
> > examples of patches that we carry in our trees that didn't get
> > accepted into the community one - luckily they're of smaller size).
> 
> I think Oracle carrying this patch in their tree is probably the best
> approach for now.

Agreed.  We can always take a patch reserving hypercall numbers for now,
so there's no risk that an Oracle private patch will clash with an
upstream allocation later on.

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel