Re: [Xen-devel] [PATCH 2 of 4] minios/console: console_input() weak reference

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Ian Campbell, le Tue 27 Nov 2012 11:46:41 +0000, a écrit :
> > > And by extension I suppose xencons_tx too, for parity if nothing else.
> > 
> > I actually wonder what the purpose of xencons_tx is.
> 
> I suppose if you had a shared ring serial console you could accept
> input?

I'm afraid I still don't understand :)

> > > The existing console_input function (previously xencons_rx) is pretty
> > > odd, it relies on something reusing a tx buffer for rx?
> > 
> > ? I don't see what you are referring to.
> 
> xencons_rx says /* Just repeat what's written */ and prints the contents
> of the buffer

Yes, it echoes what was typed on the console by the user.

> (this is rx remember, so buffer ought to be an output buffer, not
> input)

Really?  It's not what I understand from console_handle_input, which
just consumes data from the ring and gives it to xencons_rx, without
emiting any.

Samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel