Re: [Xen-devel] [PATCH VTPM v4 3/5] vtpm/vtpmmgr and required libs to stubdom/Makefile

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2012-11-20 at 14:21 +0000, Matthew Fioravante wrote:
> 
> +tpm_emulator-$(XEN_TARGET_ARCH): tpm_emulator-$(TPMEMU_VERSION).tar.gz
> +       tar xzf $<
> +       mv tpm_emulator-$(TPMEMU_VERSION) $@
> +       patch -d $@ -p1 < tpmemu-$(TPMEMU_VERSION).patch;
> +       mkdir $@/build
> +       cd $@/build; cmake .. -DCMAKE_C_COMPILER=${CC} 
> -DCMAKE_C_FLAGS="-std=c99 -DTPM_NO_EXTERN $(TARGET_CPPFLAGS) $(TARGET_CFLAGS) 
> -Wno-declaration-after-statement"
> +       touch $@ 

Ian -- is the test system ready to copy with this cmake requirement?

Or do we need to make this dependency conditional?

I think at the very least it should be $(CMAKE), at which point we may
as well go the whole hog and make configure.ac do the right thing.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel