Re: [Xen-devel] [xen-unstable test] 14426: regressions - FAIL

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2012-11-20 at 01:02 +0000, xen.org wrote:
> build-amd64-pvops             4 kernel-build              fail REGR. vs. 14416

+ hg clone http://xenbits.xen.org/hg/staging/xen-unstable.hg xen-unstable
requesting all changes
adding changesets
adding manifests
adding file changes
transaction abort!
rollback completed
abort: Connection reset by peer

An infra or network error I suppose.

>  test-amd64-i386-xend-winxpsp3  8 guest-saverestore        fail REGR. vs. 
> 14416
>  test-amd64-i386-win           8 guest-saverestore         fail REGR. vs. 
> 14416
>  test-amd64-i386-pv           10 guest-saverestore         fail REGR. vs. 
> 14416
>  test-amd64-i386-win-vcpus1    8 guest-saverestore         fail REGR. vs. 
> 14416
>  test-amd64-i386-pair   17 guest-migrate/src_host/dst_host fail REGR. vs. 
> 14416

2012-11-19 23:06:25 Z executing ssh ... root@xxxxxxxxxxxx xm migrate 
debian.guest.osstest bush-cricket
Error: XendOptionsFile instance has no attribute 'get_external_migration_tool'

This is a consequence of 26167:31dcc0e08754 "xend: Remove old vtpm
support from xm" which removed get_external_migration_tool but left one
caller.

Rather than further excise this call I think we should apply the
following patch to put back the basic external migration tool
infrastructure (with s/TPM/device/). Although the comments refer to vtpm
I can't see any reason why people might not be using it for other
purposes. Plus I'm more confident of this fix.

8<----------------------------------

# HG changeset patch
# User Ian Campbell <ijc@xxxxxxxxxxxxxx>
# Date 1353402857 0
# Node ID 4c3b6252b129152bd9497ec77aed4779c04a522b
# Parent  ae6fb202b233af815466055d9f1a635802a50855
xend: reinstate XendOptionsFile.get_external_migration_tool

This was removed by 26167:31dcc0e08754 "xend: Remove old vtpm support
from xm" but at least one caller was left. Reinstate with
s/TPM/device/ since it appears that this functionality could apply
elsewhere.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

diff -r ae6fb202b233 -r 4c3b6252b129 tools/python/xen/xend/XendOptions.py
--- a/tools/python/xen/xend/XendOptions.py      Tue Nov 20 08:58:31 2012 +0100
+++ b/tools/python/xen/xend/XendOptions.py      Tue Nov 20 09:14:17 2012 +0000
@@ -349,6 +349,10 @@ class XendOptions:
         else:
             return None
 
+    def get_external_migration_tool(self):
+        """@return the name of the tool to handle virtual device migration."""
+        return self.get_config_string('external-migration-tool', 
self.external_migration_tool_default)
+
     def get_enable_dump(self):
         return self.get_config_bool('enable-dump', 'no')
 
diff -r ae6fb202b233 -r 4c3b6252b129 tools/python/xen/xend/tests/xend-config.sxp
--- a/tools/python/xen/xend/tests/xend-config.sxp       Tue Nov 20 08:58:31 
2012 +0100
+++ b/tools/python/xen/xend/tests/xend-config.sxp       Tue Nov 20 09:14:17 
2012 +0000
@@ -127,3 +127,5 @@
 # Whether to enable core-dumps when domains crash.
 #(enable-dump no)
 
+# The tool used for initiating virtual device migration
+#(external-migration-tool '')




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel