Re: [Xen-devel] [PATCH VTPM 9/9] vtpm/vtpmmgr and required libs to stubdom/Makefile

[Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>]

On 11/13/2012 05:50 AM, Ian Campbell wrote:
> On Thu, 2012-11-01 at 20:35 +0000, Matthew Fioravante wrote:
> > Add 3 new libraries to stubdom:
> > libgmp
> > polarssl
> > Berlios TPM Emulator 0.7.4
> >
> > Also adds makefile structure for vtpm-stubdom and vtpmmgrdom
> >
> > Signed-off-by: Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>
> Patch 7, 8 & 9 all:
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
>
> (I must confess I did not review in detail, but it is all self contained
> and has an active maintainer...)
>
> However rather than apply straight away I have downloaded these three
> files:
> ftp://ftp.gmplib.org/pub/gmp-4.3.2/gmp-4.3.2.tar.bz2
> http://polarssl.org/code/releases/polarssl-1.1.4-gpl.tgz
> http://download.berlios.de/tpm-emulator/tpm_emulator-0.7.4.tar.gz
> with checksums:
> $ sha256sum gmp-4.3.2.tar.bz2 polarssl-1.1.4-gpl.tgz tpm_emulator-0.7.4.tar.gz
> 936162c0312886c21581002b79932829aa048cfaf9937c6265aeaa14f1cd1775  
> gmp-4.3.2.tar.bz2
> 2d29fd04a0d0ba29dae6bd29fb418944c08d3916665dcca74afb297ef37584b6  
> polarssl-1.1.4-gpl.tgz
> 4e48ea0d83dd9441cc1af04ab18cd6c961b9fa54d5cbf2c2feee038988dea459  
> tpm_emulator-0.7.4.tar.gz
> $
> and placed them at the $(XEN_EXTFILES_URL).
>
> Please could you confirm that these are correct and respin to use
> XEN_EXTFILES_URL?
Changed it to use extfiles and the files you added work. Will be in next 
round of patches.
> > diff --git a/stubdom/Makefile b/stubdom/Makefile
> > index 50ba360..96801b2 100644
> > --- a/stubdom/Makefile
> > +++ b/stubdom/Makefile
> > @@ -31,6 +31,18 @@ GRUB_VERSION=0.97
> >   OCAML_URL?=http://caml.inria.fr/pub/distrib/ocaml-3.11
> >   OCAML_VERSION=3.11.0
> >   
> > +GMP_VERSION=4.3.2
> > +#GMP_URL?=$(XEN_EXTFILES_URL)
> > +GMP_URL?=ftp://ftp.gmplib.org/pub/gmp-$(GMP_VERSION)
> This is a 2010 release -- any plans to upgrade to the more recent 5.x
> stream?
I didn't have any plans to as its working as intended with the current 
version. Actually I'd really like to switch vtpm-stubdom to using 
polarssl's bignum library and get rid of the large gmp dependency 
entirely. The vtpm only uses a very small part of gmp, namely bignum 
integer math for doing rsa. I don't have a whole lot of time to do this 
switch right now though.
>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel