[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] ACPI/cpuidle: remove unused "power" field from Cx state data



>>> On 02.11.12 at 14:55, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> wrote:
> On Fri, Nov 02, 2012 at 01:12:05PM +0000, Jan Beulich wrote:
>> It has never been used for anything, and Linux 3.7 doesn't propagate
>> this information anymore.
>> 
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> ---
>> Konrad, on the pv-ops side it may be better to pass zero rather than
>> leaving the field completely uninitialized.
> 
> I think this got taken care of by:
> 
> commit c59687f8466df36633d937cc298aad465d704990
> Author: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> Date:   Wed Sep 5 15:13:48 2012 +0200
> 
>     cpuidle / ACPI : remove power from acpi_processor_cx structure
>     
>     Remove the unused power field from struct struct acpi_processor_cx.
>     
>     [rjw: Modified changelog.]

That's the commit I was referring to.

> And the the xen_processor_cx is allocated using kcalloc which resets
> everything to zero - so I think we are safe there.

And that I didn't pay attention to - sorry for the noise then.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.