Re: [Xen-devel] [PATCH] fix vfb related assertion problem when starting pv-domU

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2012-11-01 at 02:18 +0000, Ronny Hegewald wrote:
> When a config-file for a pv-domU has a vfb section with a vnc=0 option then a 
> "xl create" for that domU crashes with the message
> 
> 
> xl: libxl.c:252: libxl_defbool_val: Assertion `!libxl_defbool_is_default(db)' 
> failed.
> 
> 
> and the domU hangs early in the start.
> 
> This patch fixes the cause of the assertion and let the domU start normally.
> 
> This problem exists since xen 4.2.

This seems like a good fix, in order to for us to apply it please can
you "sign off" as described in
http://wiki.xen.org/wiki/Submitting_Xen_Patches#Signing_off_a_patch

I do wonder if perhaps libxl__device_vfb_add ought to be gating a bunch
of those accesses on vnc.enabled though.

Ian.
> 
> --- tools/libxl/libxl.c.org   2012-11-01 01:35:52.000000000 +0000
> +++ tools/libxl/libxl.c       2012-11-01 01:36:20.000000000 +0000
> @@ -2949,6 +2949,8 @@ int libxl__device_vfb_setdefault(libxl__
>          }
>  
>          libxl_defbool_setdefault(&vfb->vnc.findunused, true);
> +    } else {
> +        libxl_defbool_setdefault(&vfb->vnc.findunused, false);
>      }
>  
>      libxl_defbool_setdefault(&vfb->sdl.enable, false);
> 
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel