Re: [Xen-devel] [Patch 4/5] X86/vMCE: handle broken page occurred before migration

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.10.12 at 16:21, "Liu, Jinsong" <jinsong.liu@xxxxxxxxx> wrote:
> @@ -1568,6 +1577,28 @@
>      }
>      break;
>  
> +    case XEN_DOMCTL_set_broken_page_p2m:
> +    {
> +        struct domain *d;
> +        p2m_type_t pt;
> +        unsigned long pfn;
> +
> +        d = rcu_lock_domain_by_id(domctl->domain);
> +        if ( d != NULL )
> +        {
> +            pfn = domctl->u.set_broken_page_p2m.pfn;
> +
> +            get_gfn_query(d, pfn, &pt);

Is it correct to ignore the return value here, and to act on any
value returned in "pt"?

> +            p2m_change_type(d, pfn, pt, p2m_ram_broken);

What if the operation failed (i.e. you get back a type not
matching "pt")? This can happen because __get_gfn_type_access(),
other than what p2m_change_type() does, is not just a plain call
to p2m->get_entry().

Jan

> +            put_gfn(d, pfn);
> +
> +            rcu_unlock_domain(d);
> +        }
> +        else
> +            ret = -ESRCH;
> +    }
> +    break;
> +
>      default:
>          ret = iommu_do_domctl(domctl, u_domctl);
>          break;



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel