Re: [Xen-devel] [PATCH] x86/MCE: Implement clearbank callback for AMD

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.10.12 at 16:46, Christoph Egger <Christoph.Egger@xxxxxxx> wrote:
>+static int k8_need_clearbank_scan(enum mca_source who, uint64_t status)
>+{
>+      switch (who) {
>+      case MCA_MCE_SCAN:
>+      case MCA_MCE_HANDLER:
>+              break;
>+      default:
>+              return 1;
>+      }
>+
>+      /* For fatal error, it shouldn't be cleared so that sticky bank
>+       * have chance to be handled after reboot by polling.
>+       */
>+      if ( (status & MCi_STATUS_UC) && (status & MCi_STATUS_PCC) )
>+              return 0;
>+      /* Spurious need clear bank */
>+      if ( !(status & MCi_STATUS_OVER)
>+          && (status & MCi_STATUS_UC) && !(status & MCi_STATUS_EN))
>+              return 1;
>+
>+      return 1;
> }

So what's the purpose of first conditionally returning 1, and then
also doing so unconditionally? Do anticipate to insert code between
the two parts within the very near future? Otherwise I'd drop the
whole if() construct.

(No need to re-submit, just let me know.)

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel