[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V3 03/10] libxl_json: Replace JSON_TRUE/FALSE by JSON_BOOL.



On Fri, 2012-10-05 at 17:27 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH V3 03/10] libxl_json: Replace 
> JSON_TRUE/FALSE by JSON_BOOL."):
> > Just wondering if maybe there ought to be an assert in each of those?
> 
> It shouldn't be an assertion.  In general these objects are
> unmarshalled from serialisations provided outside the process, so they
> may contain "wrong" things.

I assumed they were all checked before use, since otherwise why would
you be calling that particular variant of the getter, but if not then
that's fine too.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.