Re: [Xen-devel] [PATCH 08/12] add tpmfront, tpm_tis, and tpmback drivers to mini-os

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2012-10-02 at 17:20 +0100, Matthew Fioravante wrote:
> This patch adds 3 new drivers to mini-os.
> 
> tpmfront - paravirtualized tpm frontend driver
> tpmback - paravirtualized tpm backend driver
> tpm_tis - hardware tpm driver
> 
> Unfortunately these drivers were derived from GPL
> licensed linux kernel drivers so they must carry
> the GPL license. However, since mini-os now
> supports conditional compilation, hopefully these
> drivers can be included into the xen tree and
> conditionally removed from non-gpl projects.
> By default they are disabled in the makefile.
> 
> Signed-off-by: Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>
> ---
> Changes since last version:
>  * remove (or later version) clause from license

Sorry, but this was only one of the things I mentioned in my last mail.

But more generally I think rather than just reacting to review in this
case you need to you need to take a step back and proactively (re)audit
all of these files and consider for each file whether the header
accurately reflects the copyright and licensing status of the files from
which they are derived. IOW I'm afraid you are going to have to think
about each of these files one by one.

Sorry, but it is important to get copyright and licensing stuff correct.

Also, please can you start adding [PATCH vN xx/yy] to your subjects so
we can tell which is the latest posting.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel