Re: [Xen-devel] [PATCH 1/2] Add a new pvdrivers header to serve as the register of product numbers.

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Paul Durrant writes ("[Xen-devel] [PATCH 1/2] Add a new pvdrivers header to 
serve as the register of product numbers."):

> +#define PVDRIVERS_PRODUCT_LIST(EACH)                         \
> +        EACH("xensource-windows", 0x0001) /* Citrix */       \
> +        EACH("gplpv-windows",     0x0002) /* James Harper */ \
> +        EACH("experimental",      0xffff)                    \
> +        EACH(NULL,                0x0000) /* terminator */

When you said a terminator, I thought you meant macro parameters to
PVDRIVERS_PRODUCT_LIST which were invoked only between elements.

This invocation of EACH is harmful.  If the user wants to make an
array out of this, they can add it themselves.  But if they want to
make a switch statement out of it, they can't.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel