Re: [Xen-devel] [PATCH v1 4/8]: PVH setup changes...

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 21 Sep 2012, Mukesh Rathor wrote:
> @@ -500,10 +527,9 @@ void __cpuinit xen_enable_syscall(void)
>  #endif /* CONFIG_X86_64 */
>  }
>  
> -void __init xen_arch_setup(void)
> +/* Non auto translated PV domain, ie, it's not PVH. */
> +static __init void inline xen_non_pvh_arch_setup(void)
>  {
> -     xen_panic_handler_init();
> -
>       HYPERVISOR_vm_assist(VMASST_CMD_enable, VMASST_TYPE_4gb_segments);
>       HYPERVISOR_vm_assist(VMASST_CMD_enable, 
> VMASST_TYPE_writable_pagetables);
>  
> @@ -517,6 +543,15 @@ void __init xen_arch_setup(void)
>  
>       xen_enable_sysenter();
>       xen_enable_syscall();
> +}
> +
> +/* This function not called for HVM domain */
> +void __init xen_arch_setup(void)
> +{
> +     xen_panic_handler_init();
> +
> +     if (!xen_feature(XENFEAT_auto_translated_physmap))
> +             xen_non_pvh_arch_setup();
>  
>  #ifdef CONFIG_ACPI
>       if (!(xen_start_info->flags & SIF_INITDOMAIN)) {
 
IMHO having a xen_non_pvh_arch_setup function is less intuitive
than just wrapping all that code around an

if (!xen_feature(XENFEAT_auto_translated_physmap)) {


Or at least you could name the function xen_pvmmu_arch_setup.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel