Re: [Xen-devel] [PATCH 19/20] xen: remove rcu_lock_{remote_, }target_domain_by_id

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 10.09.12 at 21:49, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx> wrote:
> --- a/xen/arch/x86/physdev.c
> +++ b/xen/arch/x86/physdev.c
> @@ -106,9 +106,11 @@ int physdev_map_pirq(domid_t domid, int type, int 
> *index, int *pirq_p,
>          return physdev_hvm_map_pirq(d, type, index, pirq_p);
>      }
>  
> -    ret = rcu_lock_target_domain_by_id(domid, &d);
> -    if ( ret )
> -        return ret;
> +    d = rcu_lock_domain_by_any_id(domid);
> +    if ( d == NULL )
> +        return -ESRCH;
> +    if ( d != current->domain && !IS_PRIV_FOR(current->domain, d) )
> +        return -EPERM;

Wasn't one of the goal of the series the _removal_ of the explicit
IS_PRIV()/IS_PRIV_FOR() checks?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel