Re: [Xen-devel] [PATCH] x86/MSI: fix 2nd S3 resume with interrupt remapping enabled

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.09.12 at 16:44, Keir Fraser <keir.xen@xxxxxxxxx> wrote:
> On 07/09/2012 13:49, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:
> 
>> The first resume from S3 was corrupting internal data structures (in
>> that pci_restore_msi_state() updated the globally stored MSI message
>> from traditional to interrupt remapped format, which would then be
>> translated a second time during the second resume, breaking interrupt
>> delivery).
> 
> Doesn't that mean write_msi_msg() has a bit of a hideous interface?

It does, and we may want to clean that up. But at least this won't
go unnoticed in debug builds anymore with the added assertion,
should anyone re-add a bad use of it.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel