Re: [Xen-devel] [PATCH] timer: remove stray local_irq_enable()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 06.09.12 at 14:05, David Vrabel <david.vrabel@xxxxxxxxxx> wrote:
> From: David Vrabel <david.vrabel@xxxxxxxxxx>
> 
> migrate_timers_from_cpu() has a stray local_irq_enable() that does
> nothing (it's immediately after a spin_unlock_irq()) and has no
> matching local_irq_disable().
> 
> Signed-off-by: David Vrabel <david.vrabel@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

> --- a/xen/common/timer.c
> +++ b/xen/common/timer.c
> @@ -587,7 +587,6 @@ static void migrate_timers_from_cpu(unsigned int old_cpu)
>  
>      spin_unlock(&old_ts->lock);
>      spin_unlock_irq(&new_ts->lock);
> -    local_irq_enable();
>  
>      if ( notify )
>          cpu_raise_softirq(new_cpu, TIMER_SOFTIRQ);



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel