Re: [Xen-devel] [PATCH 4/5] xen: events, exposes evtchn_alloc_unbound_domain

[Tim Deegan <tim@xxxxxxx>]

At 20:50 +0100 on 03 Aug (1344027053), Jean Guyader wrote:
> 
> Exposes evtchn_alloc_unbound_domain to the rest of
> Xen so we can create allocated unbound evtchn within Xen.
> 
> Signed-off-by: Jean Guyader <jean.guyader@xxxxxxxxxx>

> @@ -161,18 +163,18 @@ static long evtchn_alloc_unbound(evtchn_alloc_unbound_t 
> *alloc)
>  {
>      struct evtchn *chn;
>      struct domain *d;
> -    int            port;
> +    evtchn_port_t  port;
>      domid_t        dom = alloc->dom;
> -    long           rc;
> +    int            rc;

The function returns long; if you're tidying this up to be an int, might
as well change the return type too.

>  
>      rc = rcu_lock_target_domain_by_id(dom, &d);
>      if ( rc )
>          return rc;
>  
> -    spin_lock(&d->event_lock);
> +    rc = evtchn_alloc_unbound_domain(d, &port);

This moves some of the setting of channel state before the xsm hook.
Also, the state changes lower down in this function are no longer under
the event_lock. :(

Cheers,

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel