Re: [Xen-devel] [PATCH] arm: fix gic_init_secondary_cpu.

[Tim Deegan <tim@xxxxxxx>]

At 16:43 +0000 on 01 Aug (1343839437), Ian Campbell wrote:
> Using spin_lock_irq here is unnecessary (interrupts are not yet enabled) and
> wrong (since they will get unexpectedly renabled by spin_unlock_irq).
> 
> We can just use spin_lock/spin_unlock.
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Acked-by: Tim Deegan <tim@xxxxxxx>

> Now an SMP model gets as far as hanging at dom0 "Calibrating delay loop...".
> 
> Tim, didn't you diagnose that a while ago?

I only got as far as showing that dom0 is spinning waiting for jiffies
to increase, but never taking the timer interrupts that would cause that
to happen.

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel