Re: [Xen-devel] [PATCH 6/6] libxl_dom: Call the right switch logdirty for the right DM.

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Anthony PERARD writes ("[PATCH 6/6] libxl_dom: Call the right switch logdirty 
for the right DM."):
> This patch dispatch the switch logdirty call depending on which device model
> version is running.
...
> -void libxl__domain_suspend_common_switch_qemu_logdirty
> +static void domain_suspend_switch_qemu_xen_traditional_logdirty
>                                 (int domid, unsigned enable, void *user)

If you make these functions internal you should not have them each
separately upcast the void*.  They should take the shs as a typed
pointer.

Apart from that it looks sane.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel