[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2 of 5] (V2) rombios/ata: Do not wait for BSY to be set

On 30/07/12 21:18, Pasi Kärkkäinen wrote:
> On Mon, Jul 30, 2012 at 08:47:21PM +0100, Andrew Cooper wrote:
>> I can't find any guarantee in the ATA specification that this will happen, 
>> and it
>> certainly does not with Qemu.  SeaBIOS has replaced it with a call to 
>> udelay(5)
>> instead.
>> As rombios does not have an equivalent udelay(), so replace the wait with a 
>> write
>> to port 0x80 which is whilelisted by Xen for 'a small delay'.
>>                          ^
> a small typo probably.. I think it should say "whitelisted".
> -- Pasi
 D'oh - yes.  Attached is version 2 which corrects this, and another
grammatical error in the sentence.

Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com

Attachment: rombios-ata_reset.patch
Description: Text Data

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.