[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 4/9] build: include Tools.mk first in tools/Rules.mk

On Wed, 2012-07-25 at 11:56 +0100, Roger Pau Monne wrote:
> Ian Campbell wrote:
> > On Wed, 2012-07-25 at 10:32 +0100, Roger Pau Monne wrote:
> >> Ian Campbell wrote:
> >>> On Wed, 2012-07-11 at 11:23 +0100, Roger Pau Monne wrote:
> >>>> Tools.mk should be included first, or PREFIX is not honoured in the
> >>>> other conf/ files that define the paths of several tools.
> >>> Isn't it a bug for anything which is included/defined via
> >>> $(XEN_ROOT)/Config.mk to depend on the contents of
> >>> $(XEN_ROOT)/config/Tools.mk since for anything non-tools Tools.mk would
> >>> never be included at all?
> >> $(XEN_ROOT)/Config.mk includes config/{Linux.mk/NetBSD.mk} and
> >> config/StdGNU.mk, which contain a bunch of paths, specially
> >> config/StdGNU.mk. If the tools config file is not loaded before, all
> >> this paths get set to the default value (which is probably fine in
> >> Linux), but not desirable in NetBSD if the user has specified a custom
> >> prefix.
> >>
> >> So the main problem is that the tools Makefile should include
> >> config/Tools.mk before config/StdGNU.mk, but since config/StdGNU.mk is
> >> included in $(XEN_ROOT)/Config.mk we have to either include Tools.mk
> >> before $(XEN_ROOT)/Config.mk or modify $(XEN_ROOT)/Config.mk to include
> >> Tools.mk (which is not desirable at all). I don't care that
> >> $(XEN_ROOT)/Config.mk uses the default paths when building the xen
> >> kernel, but we should honour the user set paths when installing the tools.
> > 
> > My point was that really all of these paths should move to autoconf and
> > Tools.mk.in. But for 4.2 I guess your proposed change is more
> > appropriate.
> Yes, this is just a bandaid to hide a much bigger problem we have with
> paths & makefiles in general.

OK then.

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

and applied, thanks.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.