Re: [Xen-devel] [PATCH] xl: support empty CDROM devices

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2012-07-25 at 11:47 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] [PATCH] xl: support empty CDROM 
> devices"):
> > On Wed, 2012-07-25 at 11:15 +0100, Ian Campbell wrote:
> > > xend accepts ',hdc:cdrom,r'[0] as an empty CDROM drive however this is
> > > not consistent with the xl syntax in
> > > docs/misc/xl-disk-configuration.txt which
> > > requires ',,hdc:cdrom,r' (the additional positional paramter is the
> > > format).
> > > I'm not sure if/how this can be fixed. Note that xend does not accept
> > > ',,hdc:cdrom,r' 
> > 
> > This can be fixed with the following hack to the parser. Effectively it
> > says that when target is given as a positional parameter and is blank
> > then format is implicitly "empty" and must be omitted.
> 
> I don't like this because it will live with us for evermore.  We will
> never be able to get rid of the weird wrinkle in the positional
> syntax.

I thought the positional syntax was deprecated, but rereading the doc I
see it is not and it is only the
"[<format>:][<target>],<vdev>[:<devtype>],<access>" syntax which is
deprecated. The problematic ",hdc:cdrom,r" is actually a special case of
this deprecated syntax.

> Maybe it would be better to do something ad hoc.  I have an idea which
> I will try to implement...

OK.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel