[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] libxl: fix comment regarding bootloader disk lifetime

Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

 tools/libxl/libxl_internal.h |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
index 43bb69b..02625a6 100644
--- a/tools/libxl/libxl_internal.h
+++ b/tools/libxl/libxl_internal.h
@@ -2011,9 +2011,11 @@ struct libxl__bootloader_state {
     /* Should be zeroed by caller on entry.  Will be filled in by
      * bootloader machinery; represents the local attachment of the
      * disk for the benefit of the bootloader.  Must be detached by
-     * the caller using libxl__device_disk_local_detach, but only
-     * after the domain's kernel and initramfs have been loaded into
-     * memory and the file references disposed of. */
+     * the caller using libxl__device_disk_local_detach.
+     * (This is safe to do after ->callback() has happened since
+     * the domain's kernel and initramfs will have been copied
+     * out of the guest's disk into a temporary directory, mapped
+     * as file references, and deleted. */
     libxl_device_disk localdisk;
     uint32_t domid;
     /* outputs:
tg: (a41a65f..) t/xen/xl.fix.bootloader-disk-detach-comment (depends on: 

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.